Ticket #1004 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

setup.py does not work when checking out source from svn

Reported by: anze Owned by: mitar
Milestone: 2.6 Component: other
Severity: minor Keywords:
Cc: janez, ales Blocking:
Blocked By:

Description

Steps to reproduce:

svn checkout --ignore-externals http://orange.biolab.si/svn/orange/trunk orange
cd orange/orange
python setup.py build

The cause of errors is the location of folder source. setup.py script expects folder source in current directory while location of this folder in svn is ../source.

Do any of the existing scripts depend on this behavior of setup.py? Will fixing it break something else?

Change History

comment:1 Changed 3 years ago by mitar

  • Cc janez added

I think we have here a bigger problem. It was always assumed that you have source inside the orange dir so that once you make inside the source you get files in the right place.

Normal code structure is often that C/C++ code is in a separate directory. The way we have it know.

I think we should fix this once for all: we should use setup.py for all compiling and installation and also for local development installations. It does support symlinking/staging local files. So there would be no need to manually checkout code to proper location, running make and so on ...

comment:2 Changed 3 years ago by mitar

  • Cc ales added

comment:3 Changed 3 years ago by anze

  • Status changed from new to closed
  • Resolution set to fixed

setup.py was added to root in #12356. #12610 adds MANIFEST.in which fixes package generation using setup.py sdist.

Note: See TracTickets for help on using tickets.