Ticket #1097 (closed task: fixed)

Opened 3 years ago

Last modified 2 years ago

Remove redundant classes and functions in Orange.feature.selection

Reported by: janez Owned by: blaz
Milestone: 2.5 Component: documentation
Severity: minor Keywords:
Cc: Blocking:
Blocked By:


Blaž, this should be trivial - you'll just have to remove some code, not program it anew, like in discretization.

Orange.feature.selection seems to me to have many redundant classes and functions, including, for instance, FilterAboveThreshold, which is documented as (please print this out and pin to the board in the corridor):

Store filter parameters that are later called with the data to return the data table with only selected features.

I moved the general documentation to .rst, cleaned up the arguments, rewrote some functions ... but I don't know which functions/classes to remove. Please decide about that and them reassign me the ticket so that I complete the documentation (or you can complete it yourself).

Change History

comment:1 Changed 3 years ago by janez

I have cleaned it up some more, now you can just remove what you don't want (or keep everything if you will).

Please also consider what to do with examples. They refer to OFB, construct classes that are too long and ugly and even still contain HTML tags! I guess it's much better to remove it than to keep it like it is.

comment:2 Changed 2 years ago by blaz

  • Status changed from new to closed
  • Resolution set to fixed

Fixed (somehow), but needs work and rewriting in future versions.

Note: See TracTickets for help on using tickets.