Ticket #1100 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Refactoring of Orange.classification.rules

Reported by: janez Owned by: matija
Milestone: 2.5 Component: library
Severity: minor Keywords:
Cc: blaz Blocking:
Blocked By:

Description

This is what we have:

from Orange.core import \

RuleClassifier, \ RuleClassifier_firstRule, \ RuleClassifier_logit, \ RuleLearner, \ Rule, \ RuleBeamCandidateSelector, \ RuleBeamCandidateSelector_TakeAll, \ RuleBeamFilter, \ RuleBeamFilter_Width, \ RuleBeamInitializer, \ RuleBeamInitializer_Default, \ RuleBeamRefiner, \ RuleBeamRefiner_Selector, \ RuleClassifierConstructor, \ RuleCovererAndRemover, \ RuleCovererAndRemover_Default, \ RuleDataStoppingCriteria, \ RuleDataStoppingCriteria_NoPositives, \ RuleEvaluator, \ RuleEvaluator_Entropy, \ RuleEvaluator_LRS, \ RuleEvaluator_Laplace, \ RuleEvaluator_mEVC, \ RuleFinder, \ RuleBeamFinder, \ RuleList, \ RuleStoppingCriteria, \ RuleStoppingCriteria_NegativeDistribution, \ RuleValidator, \ RuleValidator_LRS

I guess we should remove the Rule prefix from all names (like we did for trees).

If we do this, please assign the task to somebody who's already done refactoring (I haven't and will surely miss something). When this is done, please tell me, so I can get pickling to work again – for pickling to work, the C++ classes must know their correct outside big-Orange name.

Change History

comment:1 Changed 3 years ago by janez

  • Component changed from bioinformatics add-on to library

comment:2 Changed 3 years ago by marko

  • Owner changed from marko to matija
  • Status changed from new to assigned

RuleClassifier, RuleLearner (and similar) should stay as they are, but others, like RuleEvaluator_Entropy should be renamed (RuleEvaluator_Entropy -> EvaluaterEntropy).

comment:3 Changed 3 years ago by janez

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.