Ticket #354 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

GO Enrichment Analysis (Filter)

Reported by: blaz Owned by: ales
Milestone: Future Component: canvas
Severity: major Keywords:
Cc: Blocking:
Blocked By:

Description

Kontroli (slider-ja) v "Filter GO Term Nodes" v widgetu "GO Enrichment Analysis" je prakticno nemogoce uporabljati (za nastavitev natancnih vrednosti; poskusi Number of instances nastaviti na 2). Jih lahko zamenjas z kontrolami za neposredni vnos, kot sta npr. "Intervals" v Rank widgetu. Tudi spremeni labele:

Filter GO Term Nodes -> Filter Number of instances -> "Genes:" p-value -> "Significance:"

Attachments

filter.png Download (1.6 KB) - added by blaz 5 years ago.
snapshot of filter controls
entry-box.png Download (501 bytes) - added by blaz 5 years ago.
replace with this type of controls

Change History

Changed 5 years ago by blaz

snapshot of filter controls

Changed 5 years ago by blaz

replace with this type of controls

comment:1 Changed 5 years ago by anonymous

  • Status changed from new to closed
  • Resolution set to fixed

comment:2 Changed 5 years ago by blaz

  • Status changed from closed to reopened
  • Resolution fixed deleted

Ales, tole se ne dela dobro. Prosim, za obe polji, uporabi kontrolo ki sprejme stevilko sele takrat, ko se spremeni focus oz. ko pritisnem return (ta kontrola tudi, ob spreminjanju polja, doda kvadratek za return na desni od polja). Poglej Rank widget za primer.

Problem pri sedanji implementaciji je, da pri vsaki spremebi stevilke GO hoce zrenderirati drevo, kar zadevo upocasni. Tudi, npr., ce je prejsnja stevilka 0.001, pa "1" zbrisem, se zadeva mnogokrat usuje.

Tudi, za p, dovoli stevila, ki so nizja od 0.001 (npr., naj bo moc vpisati 0.0000001).

GO widget se sicer precej hitro sesuje. En bug, ki se mi pojavlja, je tipa:

Unhandled exception of type KeyError occured at 9:38:59: Traceback:

File: orngSignalManager.py, line 61 in call Code: self.method(*k)

File: OWGUI.py, line 1309 in call Code: self.f(kwds)

File: OWGOEnrichmentAnalysis.py, line 516 in FilterAndDisplayGraph Code: self.DisplayGraph()

File: OWGOEnrichmentAnalysis.py, line 564 in DisplayGraph Code: addNode(self.treeStructRootKey, None, self.listView)

File: OWGOEnrichmentAnalysis.py, line 562 in addNode Code: for c in self.treeStructDict[term].children:

KeyError: 'GO:0008150'

comment:3 Changed 5 years ago by blaz

  • Type changed from wish to bug

Po novem se mi tudi, ko hocem GO widget spraviti na canvas, pojavlja tale bug:

Traceback:
  File: orngDoc.py, line 246 in addWidget
  Code: newwidget = orngCanvasItems.CanvasWidget(self.signalManager, self.canvas, self.canvasView, widgetInfo, self.canvasDlg.defaultPic, self.canvasDlg, widgetSettings)
    File: orngCanvasItems.py, line 123 in __init__
    Code: self.instance.__init__(signalManager=signalManager)
      File: OWGOEnrichmentAnalysis.py, line 134 in __init__
      Code: OWGUI.doubleSpin(OWGUI.indentedBox(box), self, 'maxPValue', 1e-8, 1, step=1e-8, label='p:', labelWidth=15, callback=self.FilterAndDisplayGraph, callbackOnReturn=True)
        TypeError: doubleSpin() got an unexpected keyword argument 'callbackOnReturn' 

(torej, brez da ocistim registry, widgeta sploh ne morem uporabljati).

comment:4 Changed 5 years ago by ales

Posodobi OWGUI.py v orange/OrangeWidgets. Za doubleSpin sem moral dodati kontrole za focus out.

comment:5 Changed 5 years ago by ales

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.